Conversation
This comment has been minimized.
This comment has been minimized.
dc893bc to
7c629a2
Compare
This comment has been minimized.
This comment has been minimized.
|
Next Tuesday I'll add to this PR . properties files for the two metadata blocks |
|
I put the two properties files for the metadata blocks into this branch's src/main/java/propertyFiles folder |
This comment has been minimized.
This comment has been minimized.
ef2f080 to
db4c453
Compare
This comment has been minimized.
This comment has been minimized.
db4c453 to
44e2c17
Compare
This comment has been minimized.
This comment has been minimized.
44e2c17 to
e41d0e3
Compare
This comment has been minimized.
This comment has been minimized.
Co-authored-by: Oliver Bertuch <poikilotherm@users.noreply.github.com>
This comment has been minimized.
This comment has been minimized.
As of be670d4 we are putting "required" in review.tsv so in this commit we are updating the test code to no longer set "required" at the collection level.
This comment has been minimized.
This comment has been minimized.
| if (existingDatasetType != null) { | ||
| // A dataset type can be specified via API, for example. | ||
| theDataset.setDatasetType(existingDatasetType); | ||
| List<DatasetType> allowedByCollection = theDataset.getOwner().getAllowedDatasetTypes(); |
There was a problem hiding this comment.
@scolapasta found a bug in this part of the code. As of 050439d, in JSF, one is still able to create a dataset in a collection that only allows review. I have a fix ready, which I'll push.
There was a problem hiding this comment.
Fixed in 2b03a64. Here's how the error looks in JSF:
#11747 Prior to this fix, you could create a dataset via JSF in a collection where allowedDatasetTypes included only "review", for example.
This comment has been minimized.
This comment has been minimized.
2 similar comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
allowedDatasetTypes is for collections. linkedMetadataBlocks is for dataset types.
This comment has been minimized.
This comment has been minimized.
|
Based on testing, I made the following changes: 2b03a64 better handling of collections disallowing "dataset" datasetType #12115 #11747 I also opened the following issue which can be observed in this pull request as well as the "develop" branch: |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
1 similar comment
|
📦 Pushed preview images as 🚢 See on GHCR. Use by referencing with full name as printed above, mind the registry name. |
What this PR does / why we need it:
Makes creation of review datasets possible.
Which issue(s) this PR closes:
Special notes for your reviewer:
Suggestions on how to test this:
<resourceType resourceTypeGeneral="Other">Review</resourceType>Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Dataset Type facet values are now lowercase
The facets under "Dataset Type" are changing from human readable and translatable ("Dataset" from getDisplayName) to machine-readable ("dataset" from getName). This is to fix #11758 and IQSS/dataverse-frontend#809
Before
After
Note that I'm aware that even after this fix, when you click any of the machine readable names, such as "software", the friendly name will appear above the search results like this:
I left a note in the xhtml about this. I don't think this is worth fixing on the JSF side. In the SPA, the values will consistently be the machine readable versions, such as "software" (lower case).
Review Metadata/Item Reviewed
Also, a "Review Metadata" block has been added. The primary field is "Item Reviewed" (#12015) and it looks like this (see IQSS/dataverse-frontend#876 (comment) for how it looks in the SPA):
Dataset Type dropdown (SPA only)
The "Dataset Type" dropdown does not appear in JSF but here's how it looks in the SPA (see IQSS/dataverse-frontend#876 (comment) for more context):
If allowedDatasetTypes does not include "dataset"
If you have configured a collection to only allow "review" (or only "software", or only "review" and "software" or whatever but not "dataset") for allowedDatasetTypes, you will get an error in JSF if you try to create a "dataset" dataset type (which is the only dataset type JSF knows how to create), like this:
Is there a release notes update needed for this change?:
Included